[ 
https://issues.apache.org/jira/browse/WICKET-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021467#comment-17021467
 ] 

ASF subversion and git services commented on WICKET-6726:
---------------------------------------------------------

Commit ec8c759c15259ab5c51a4416a31100e5665be418 in wicket's branch 
refs/heads/csp-form from Emond Papegaaij
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=ec8c759 ]

WICKET-6726: move inline JS to an event handler


> CSP: inline styling and js in Form submitbutton handling
> --------------------------------------------------------
>
>                 Key: WICKET-6726
>                 URL: https://issues.apache.org/jira/browse/WICKET-6726
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>            Reporter: Emond Papegaaij
>            Assignee: Emond Papegaaij
>            Priority: Major
>
> org.apache.wicket.markup.html.form.Form#appendDefaultButtonField : this piece 
> is just ridiculous to have in 2019
> {code:java}
> buffer.append(String.format("<div 
> style=\"width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hidden\"
>  class=\"%s\">", cssClass));
> {code}
> org.apache.wicket.markup.html.form.Form#appendDefaultButtonField
> {code:java}
> buffer.append(defaultSubmittingComponent.getInputName());
> buffer.append("\" onclick=\" var b=document.getElementById('");
> buffer.append(submittingComponent.getMarkupId());
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to