This is an automated email from the ASF dual-hosted git repository.
papegaaij pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/master by this push:
new 3f6a5d3 WICKET-6732: Do not render URL when link is disabled or
invisible
3f6a5d3 is described below
commit 3f6a5d3b16450d074b138e09160297c568707fd5
Author: Emond Papegaaij <[email protected]>
AuthorDate: Fri Feb 7 15:53:21 2020 +0100
WICKET-6732: Do not render URL when link is disabled or invisible
---
.../main/java/org/apache/wicket/markup/html/link/ExternalLink.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
index ce414d4..3217ee3 100644
---
a/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
+++
b/wicket-core/src/main/java/org/apache/wicket/markup/html/link/ExternalLink.java
@@ -178,8 +178,13 @@ public class ExternalLink extends AbstractLink
{
super.renderHead(response);
+ if (!isEnabledInHierarchy())
+ {
+ return;
+ }
+
String url = renderUrl();
- if (isEnabledInHierarchy() && url != null)
+ if (url != null)
{
if (popupSettings != null)
{
