This is an automated email from the ASF dual-hosted git repository.

reiern70 pushed a commit to branch 
improvement/reiern70/WICKET-6750-client-side-abortion-of-ajax-requests
in repository https://gitbox.apache.org/repos/asf/wicket.git


The following commit(s) were added to 
refs/heads/improvement/reiern70/WICKET-6750-client-side-abortion-of-ajax-requests
 by this push:
     new 90556bd  [WICKET-6750] improve comment
90556bd is described below

commit 90556bdb0d2a6263b5399dd02de8a411ef721a72
Author: reiern70 <[email protected]>
AuthorDate: Wed Feb 26 11:59:23 2020 +0200

    [WICKET-6750] improve comment
---
 .../apache/wicket/ajax/res/js/wicket-ajax-jquery.js   | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git 
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js 
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index 401ad41..8a66ad7 100644
--- 
a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++ 
b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -583,11 +583,20 @@
                },
 
                /**
-                * Aborts current AJAX request, if any is running, for default 
channel.
-                * WARNING! Mind that this does not implies and server 
immediately will know about
-                * request being aborted and server side processing (and page 
lock night continue).
-                * This method might prove useful, for instance, in order to 
abort big AJAX
-                * uploads.
+                * Aborts current AJAX request, if any is running, for channel 
@channel.
+                *
+                * WARNING! Mind that this does not implies the server will 
immediately know about
+                * request being aborted. And there is no reliable way to tell 
server to stop process
+                * started by halted request. Thus server side processing of 
request and, by consequence,
+                * Wicket's lock on page night continue. Therefore any 
following AJAX requests might need to wait at
+                * server side for lock on page to be released. Nevertheless, 
this method might prove useful, for instance,
+                * in order to abort/halt big AJAX uploads.
+                *
+                * TODO: implement some kind of client side mechanism + server 
side counterpart allowing to tell server
+                * please discard/request + release page lock?
+                *
+                * @param {String} channel - the name of the channel. If no 
parameter is provided then default channel is
+                *        assumed.
                 */
                abortRequest: function (channel) {
                        var attr = {};

Reply via email to