[ 
https://issues.apache.org/jira/browse/WICKET-6753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051954#comment-17051954
 ] 

Sven Meier commented on WICKET-6753:
------------------------------------

[~robert.murphy] Your fix has an error too: 

Wicket.Window.getMarkup() correctly uses attribute "aria-labelledby" to link 
the window's <div> with the id of the caption's <hr3>.

But you're right in that setting "aria-labelledby" from show() and 
updateTitle() is wrong. But can't we just remove these two lines?
The caption text is already updated, no need to set an "arial-label".

WDYT?

> res/modal.js using aria-labelledby where it should be using aria-label
> ----------------------------------------------------------------------
>
>                 Key: WICKET-6753
>                 URL: https://issues.apache.org/jira/browse/WICKET-6753
>             Project: Wicket
>          Issue Type: Bug
>          Components: ModalDialog, wicket-extensions
>    Affects Versions: 8.7.0
>            Reporter: Robert Murphy
>            Priority: Major
>         Attachments: modal.js
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> aria-labelledby attribute value should be the id of an element containing the 
> label for the element with the aria-labelledby attribute.  aria-label 
> attribute value contains the label for the element with the aria-label 
> attribute.  We got sued for ADA Compliance Errors.  The lawsuit cites the 
> Errors and Alerts generated by the WAVE tool (by WebAIM).
> The bug causes WAVE Error Broken ARIA reference.
> The fix:
> Instead of copying the title to the aria-labelledby attribute, don't use 
> aria-labelledby at all and instead copy the title to the aria-label attribute.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to