[
https://issues.apache.org/jira/browse/WICKET-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062906#comment-17062906
]
ASF subversion and git services commented on WICKET-6756:
---------------------------------------------------------
Commit 1db8b1c2778b435b51a84e1354dbb56475b23855 in wicket's branch
refs/heads/master from Thorsten Schöning
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=1db8b1c ]
WICKET-6756 Avoid URL.getFile()
Another place where "URL.getFile()" is forwarded to "FileOutputStream"
without caring about proper decoding.
> Avoid URL.getFile() when actually expecting paths.
> --------------------------------------------------
>
> Key: WICKET-6756
> URL: https://issues.apache.org/jira/browse/WICKET-6756
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 8.7.0
> Reporter: Thorsten Schöning
> Priority: Major
>
> [WICKET-6714|https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6714]
> introduced using "URL.getFile" to convert some parts of an URL to a path in
> the local file system. This doesn't work properly, because the result of
> "getFile" is not properly decoded e.g. in case the URL/path contains spaces.
> While this concrete issue has been fixed by
> [WICKET-6714|https://issues.apache.org/jira/projects/WICKET/issues/WICKET-6755]
> already, in theory this needs to be fixed i the entire code base as well.
> Each place URL.getFile is used to get some local file system path is wrong.
> https://stackoverflow.com/questions/2166039/java-how-to-get-a-file-from-an-escaped-url
> This is issue is created to make aware of that problem and because during
> WICKET-6755 I've found at least one additional place already where this
> problem happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
