[
https://issues.apache.org/jira/browse/WICKET-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063341#comment-17063341
]
ASF subversion and git services commented on WICKET-6759:
---------------------------------------------------------
Commit 6d453fa39978d921f15dfdba8f1a515b86feb0d0 in wicket's branch
refs/heads/master from Thomas
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=6d453fa ]
WICKET-6759 Add `shouldNotifyOnErrorEvent` filter function to
`WebSocketSettings` (#416)
> Support disabling error notification for websockets
> ---------------------------------------------------
>
> Key: WICKET-6759
> URL: https://issues.apache.org/jira/browse/WICKET-6759
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-native-websocket
> Affects Versions: 8.7.0
> Reporter: Thomas Heigl
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
>
> Hi,
> WebSocketSettings currently supports disabling the broadcast of `close`
> events. This toggle has been added because notifications lead to
> deserialization of the page instance from the page store:
> {code:java}
> /**
> * A function that decides whether to notify the page/resource on
> * web socket connection closed event.
> * The page notification leads to deserialization of the page instance
> from
> * the page store and sometimes this is not wanted.
> */
> private Function<Integer, Boolean> notifyOnCloseEvent = (code) -> true;
> {code}
> The same happens for `error` events, but it is not possible to disable the
> notification.
> Would it be possible to add another toggle `setNotifyOnErrorEvent`?
> I can provide a PR if necessary.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
