[ 
https://issues.apache.org/jira/browse/WICKET-6758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064596#comment-17064596
 ] 

ASF subversion and git services commented on WICKET-6758:
---------------------------------------------------------

Commit 716e10e5dc79e0a91520733c509e1b24c6e03e81 in wicket's branch 
refs/heads/wicket-7.x from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=716e10e ]

WICKET-6758 NPE in AbstractWebSocketProcessor after session times out

Return early if there is no Wicket Session while processing WebSocket message

(cherry picked from commit 1f6f8ba54bc921c11e1b8462dc03f33e94f5b06f)


> NPE in AbstractWebSocketProcessor after session times out
> ---------------------------------------------------------
>
>                 Key: WICKET-6758
>                 URL: https://issues.apache.org/jira/browse/WICKET-6758
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-native-websocket
>    Affects Versions: 8.7.0
>            Reporter: Thomas Heigl
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>
> Hi all,
> I'm seeing NPEs when processing websocket messages after the session has 
> timed out:
> {code:java}
> java.lang.NullPointerException: null
>       at 
> org.apache.wicket.protocol.ws.api.AbstractWebSocketProcessor.broadcastMessage(AbstractWebSocketProcessor.java:245)
>       at 
> org.apache.wicket.protocol.ws.api.AbstractWebSocketProcessor.onConnect(AbstractWebSocketProcessor.java:181)
>       at 
> org.apache.wicket.protocol.ws.javax.JavaxWebSocketProcessor.<init>(JavaxWebSocketProcessor.java:18)
>       at 
> org.apache.wicket.protocol.ws.javax.WicketEndpoint.onOpen(WicketEndpoint.java:41)
>       at 
> org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.init(WsHttpUpgradeHandler.java:133)
>       at 
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:914)
>       at 
> org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1639)
>       at 
> org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>       at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>       at 
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
>       at java.base/java.lang.Thread.run(Thread.java:834) {code}
> Wicket tries to get the PageManager from the session, but the session is 
> null. This case should probably be logged like the case when the page has 
> expired.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to