[ 
https://issues.apache.org/jira/browse/WICKET-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219530#comment-17219530
 ] 

Ernesto Reinaldo Barreiro commented on WICKET-6845:
---------------------------------------------------

Hi [~mgrigorov],

This second call JavaSerializer#serialize(Page)  is what I wanted to prevent 
via a thread local (as serialization happens in a single thread). Before 
calling JavaSerializer#serialize(Page) check thread and make sure it is the 
first time it has been/will be called. That way even if thing broke somewhere 
else loop will be prevented. 


> stackoverflow while serializing a page containing a reference to session
> ------------------------------------------------------------------------
>
>                 Key: WICKET-6845
>                 URL: https://issues.apache.org/jira/browse/WICKET-6845
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 9.0.0, 9.1.0
>            Reporter: Ernesto Reinaldo Barreiro
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>             Fix For: 9.2.0
>
>         Attachments: session-serialization.tar.gz
>
>
> Something has changed in the way pages are serialized in wicket 9.x thus that 
> if a page has a reference to session serialization enters in a loop causing 
> an stack overflow. See attached  project. While there is no reasons to keep a 
> reference to session, and I have fixed that in our legacy code causing this 
> problem,  it would be nice to avoid server crashing because of this (and log 
> a huge warning for users to note).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to