[
https://issues.apache.org/jira/browse/WICKET-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227394#comment-17227394
]
Martin Tzvetanov Grigorov commented on WICKET-6847:
---------------------------------------------------
{code:java}
isPageStateless and now RequestPageStore.addPage calls Page.isPageStateless
again. IMHO this is bound to give problems. {code}
Why ?
The new code just binds an HttpSession if the page is already known to be
stateful.
If it becomes stateful at a later point in time then the new code does nothing
harmful.
I guess we need to add a new step before committing the request:
* check whether there are stateful pages to be stored and bind HttpSession if
needed
* commit request
* detach the page
If this works then my previous change could be removed as obsolete.
In any case it would be nice to have a test case demonstrating the current
issue to protect us from further regressions.
> async page storing fails with flush before detach without session
> -----------------------------------------------------------------
>
> Key: WICKET-6847
> URL: https://issues.apache.org/jira/browse/WICKET-6847
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 9.1.0
> Reporter: Sven Meier
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
> Fix For: 9.2.0
>
>
> Since WICKET-6831 the response is flushed before detach.
> RequestPageStore delays storing all of stateful pages until detach; at that
> moment AsynchronousPageStore can no longer acquire the required session id.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
