reiern70 edited a comment on pull request #479:
URL: https://github.com/apache/wicket/pull/479#issuecomment-963054657


   > About the new `pageClass` attribute:
   > 
   > * PageIdKey is no more accurate name, since it is not just the `id` 
anymore. But renaming it would be an API break
   > * What if someone wants to do the same with a resource based WebSocket 
behavior ?
   
   Good point. This is why I thought about context. Maybe call this context and 
move this to a common Ikey?
   
   > 
   > IMO we should move this logic at `IKey` level. And if we can avoid class 
loading it would be better, but I am not sure how exactly to do it yet!
   
   Ok. I will give it a try.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to