reiern70 commented on a change in pull request #481:
URL: https://github.com/apache/wicket/pull/481#discussion_r749020586
##########
File path:
wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NavigatorLabel.java
##########
@@ -46,11 +46,21 @@
public NavigatorLabel(final String id, final IPageableItems pageable)
{
super(id);
- setDefaultModel(new StringResourceModel("NavigatorLabel", this,
+ setDefaultModel(new
StringResourceModel(getNavigationLabelKey(), this,
new Model<>(new LabelModelObject(pageable))));
}
- private static class LabelModelObject implements IClusterable
+ /**
+ * Allows to override the key used for navigation label.
+ *
+ * @return The i18n key.
+ */
+ protected String getNavigationLabelKey()
Review comment:
I know all of the above. 1) we use a a single i18n file at APP level
(not my decision) 2) path is error prone and this is part of a component used
in many places in app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
