This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/wicket.git
commit 40e4e255bffa5968f9e799680bb81ccc025164ad Author: Martin Tzvetanov Grigorov <[email protected]> AuthorDate: Thu Dec 16 16:14:16 2021 +0200 Do not resolve the WebSocket IKey twice Directly call #broadcastMessage(Connection, Message) Signed-off-by: Martin Tzvetanov Grigorov <[email protected]> --- .../apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java index f2a3a93..59e49d1 100644 --- a/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java +++ b/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java @@ -81,7 +81,6 @@ public abstract class AbstractWebSocketProcessor implements IWebSocketProcessor * A pageId indicating that the endpoint is WebSocketResource */ static final int NO_PAGE_ID = -1; - static final String NO_PAGE_CLASS = "_NO_PAGE"; private final WebRequest webRequest; private final int pageId; @@ -202,7 +201,9 @@ public abstract class AbstractWebSocketProcessor implements IWebSocketProcessor { if (webSocketSettings.shouldNotifyOnErrorEvent(t)) { IKey key = getRegistryKey(); - broadcastMessage(new ErrorMessage(getApplication(), getSessionId(), key, t)); + IWebSocketConnection connection = connectionRegistry.getConnection(application, sessionId, key); + ErrorMessage message = new ErrorMessage(application, sessionId, key, t); + broadcastMessage(message, connection); } }
