[
https://issues.apache.org/jira/browse/WICKET-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517794#comment-17517794
]
ASF GitHub Bot commented on WICKET-6969:
----------------------------------------
solomax commented on code in PR #509:
URL: https://github.com/apache/wicket/pull/509#discussion_r843422972
##########
wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/WebSocketResponse.java:
##########
@@ -87,13 +100,34 @@ public void close()
{
if (text != null)
{
- connection.sendMessage(text.toString());
+ if (asynchronous)
+ {
+ if (timeout > 0)
Review Comment:
I would drop this `if` in favor of
`connection.sendMessageAsync(text.toString(), timeout);`
> allow to process web socket push messages in an asynchronous way.
> -----------------------------------------------------------------
>
> Key: WICKET-6969
> URL: https://issues.apache.org/jira/browse/WICKET-6969
> Project: Wicket
> Issue Type: Improvement
> Reporter: Ernesto Reinaldo Barreiro
> Priority: Major
>
> Currently web socket push messages are always processed in a synchronous
> way. Allow to configure applications to use by default asynchronous messages.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
