timtebeek commented on code in PR #556:
URL: https://github.com/apache/wicket/pull/556#discussion_r1133573194
##########
pom.xml:
##########
@@ -119,7 +119,8 @@
<module>wicket-native-websocket</module>
<module>wicket-bean-validation</module>
<module>wicket-user-guide</module>
- </modules>
+ <module>wicket-migration</module>
Review Comment:
Open to adopt this as requested, although I'd though to sketch how we
typically structure migrations. For comparison we also support [migrations
through major versions of
Spring](https://github.com/openrewrite/rewrite-spring/tree/main/src/main/resources/META-INF/rewrite),
which are all in the same module as separate yaml files, which are chained
together to support a migration from whatever version users are using.
If we were to adopt individual modules per major version, those modules
would then likely have a dependency chain running through them, with likely no
more than a yaml file and perhaps a few recipes per module. That could also be
managed with a package within a single migration module.
Open to adopt the structure as suggested, but if you were to ask me such a
distinction isn't necessary right now. So whatever you then think is best given
the above, and your own preferences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
