[
https://issues.apache.org/jira/browse/WICKET-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705297#comment-17705297
]
ASF GitHub Bot commented on WICKET-6915:
----------------------------------------
martin-g commented on code in PR #565:
URL: https://github.com/apache/wicket/pull/565#discussion_r1149143654
##########
wicket-commons-fileupload/src/test/java/org/apache/wicket/commons/fileupload2/util/mime/Base64DecoderTestCase.java:
##########
@@ -0,0 +1,165 @@
+/*
Review Comment:
I am not sure whether Wicket's surefire setup will run `**TestCase` named
classes.
##########
wicket-extensions/src/main/java/module-info.java:
##########
@@ -21,7 +21,8 @@
requires org.slf4j;
requires com.fasterxml.jackson.databind;
requires com.github.openjson;
- requires commons.fileupload2;
+ //commented out due to local-copy WICKET-6915 requires commons.fileupload2;
Review Comment:
ditto
##########
wicket-core/src/main/java/module-info.java:
##########
@@ -23,7 +23,8 @@
requires org.apache.wicket.request;
requires org.apache.commons.io;
requires org.apache.commons.collections4;
- requires commons.fileupload2;
+ //commented out due to local-copy WICKET-6915 requires commons.fileupload2;
Review Comment:
it is not commented out but replaced.
IMO the comment could be removed
##########
wicket-util/src/main/java/module-info.java:
##########
@@ -23,7 +23,8 @@
requires java.desktop;
requires org.apache.commons.io;
requires org.apache.commons.collections4;
- requires commons.fileupload2;
+ //commented out due to local-copy WICKET-6915 requires commons.fileupload2;
Review Comment:
ditto
##########
wicket-util/pom.xml:
##########
@@ -40,9 +40,14 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-collections4</artifactId>
</dependency>
+ <!
> Update common-fileupload to 2.0
> -------------------------------
>
> Key: WICKET-6915
> URL: https://issues.apache.org/jira/browse/WICKET-6915
> Project: Wicket
> Issue Type: Task
> Components: wicket
> Affects Versions: 10.0.0
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Fix For: 10.0.0
>
>
> commons-fileupload2 will provide implementation for jakarta.servlet-api:5.0.0
>
> At the moment it is not yet released!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
