[GitHub] [wicket] reiern70 commented on a diff in pull request #566: [WICKET-7037] add SameSite attribute to cookie.

Mon, 03 Apr 2023 01:15:32 -0700 


reiern70 commented on code in PR #566:
URL: https://github.com/apache/wicket/pull/566#discussion_r1155626715


##########
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/wicket-ajaxdownload.js:
##########
@@ -28,7 +28,7 @@
        Wicket.AjaxDownload = {
                initiate : function(settings) {
                        document.cookie = settings.name +
-                               '=;path=/;Max-Age=0;expires=Thu, 01 Jan 1970 
00:00:01 GMT';
+                               '=;path=/;Max-Age=0;expires=Thu, 01 Jan 1970 
00:00:01 GMT; SameSite=None; Secure';

Review Comment:
   Code above is from
   
   
![image](https://user-images.githubusercontent.com/462655/229451279-2930818e-9505-497d-a3d4-5404cb30f6f6.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to