[
https://issues.apache.org/jira/browse/WICKET-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710400#comment-17710400
]
ASF GitHub Bot commented on WICKET-7042:
----------------------------------------
solomax commented on code in PR #573:
URL: https://github.com/apache/wicket/pull/573#discussion_r1162329834
##########
wicket-core/src/main/java/org/apache/wicket/page/PartialPageUpdate.java:
##########
@@ -265,7 +265,7 @@ private CharSequence renderScripts(Collection<CharSequence>
scripts) {
combinedScript.append("(function(){").append(script).append("})();");
}
- StringResponse stringResponse = new StringResponse();
+ StringResponse stringResponse = new
StringResponse(combinedScript.length() + 65);
Review Comment:
magic number? :) Should it be constant with meaningful name? :))
##########
wicket-core/src/main/java/org/apache/wicket/response/StringResponse.java:
##########
@@ -30,6 +30,8 @@
public class StringResponse extends Response
{
+ private static final int DEFAULT_INITIAL_CAPACITY = 128;
Review Comment:
I believe this one should be unified with LAzyStringResponse
> Improve sizing of StringResponse when writing scripts in PartialPageResponse
> ----------------------------------------------------------------------------
>
> Key: WICKET-7042
> URL: https://issues.apache.org/jira/browse/WICKET-7042
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 9.12.0
> Reporter: Thomas Heigl
> Assignee: Thomas Heigl
> Priority: Major
>
> When rendering scripts in PartialPageResponse, an AppendingStringBuilder with
> initial capacity 1024 is created. This buffer is then written to a
> StringResponse that uses a buffer with an initial capacity of 128 causing
> unnecessary allocations.
> We should create the StringResponse with enough capacity to hold the scripts.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
