theigl commented on code in PR #573:
URL: https://github.com/apache/wicket/pull/573#discussion_r1162335300
##########
wicket-core/src/main/java/org/apache/wicket/page/PartialPageUpdate.java:
##########
@@ -265,7 +265,7 @@ private CharSequence renderScripts(Collection<CharSequence>
scripts) {
combinedScript.append("(function(){").append(script).append("})();");
}
- StringResponse stringResponse = new StringResponse();
+ StringResponse stringResponse = new
StringResponse(combinedScript.length() + 65);
Review Comment:
I wasn't sure how I would name this constant. It's the length of the script
tag plus CDATA:
```java
<script type="text/javascript">
/*<![CDATA[*/
.....
/*<![CDATA[*//*]]>*/
</script>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
