reiern70 commented on code in PR #571:
URL: https://github.com/apache/wicket/pull/571#discussion_r1166400295
##########
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/form/upload/progressbar.js:
##########
@@ -55,24 +58,39 @@
if (displayprogress) {
this.setPercent(0);
this.setStatus(this.initialStatus);
-
Wicket.$(this.statusid).removeAttribute('hidden');
- Wicket.$(this.barid).removeAttribute('hidden');
+ var $statusId = Wicket.$(this.statusid);
+ if ($statusId != null) {
+ Wicket.DOM.show($statusId);
+ }
+ var $barid = Wicket.$(this.barid)
Review Comment:
> Just curious: why `var` is used and not `let` and `const`?
If you use let and const then the project will not build. I think there is
some logic compiling and minimizing javascript and there are some settings for
a target version of JavaScript that does not allow const and let. Only vars...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
