theigl commented on code in PR #579:
URL: https://github.com/apache/wicket/pull/579#discussion_r1168181660
##########
wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java:
##########
@@ -1089,7 +1089,7 @@ public static CharSequence toMultilineMarkup(final
CharSequence s)
return null;
}
- final AppendingStringBuffer buffer = new
AppendingStringBuffer();
+ final AppendingStringBuffer buffer = new
AppendingStringBuffer((int) (s.length() * 1.1));
Review Comment:
We have the exact same logic in `Strings.escapeMarkup`:
https://github.com/apache/wicket/blob/d51883862a448e26f8d973a24756ea7e03259de7/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java#L305
A constant would have to be something like
`ESTIMATED_OVERHEAD_OF_MULTILINE_MARKUP`. I think a comment would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
