[
https://issues.apache.org/jira/browse/WICKET-7080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781819#comment-17781819
]
ASF GitHub Bot commented on WICKET-7080:
----------------------------------------
martin-g commented on code in PR #682:
URL: https://github.com/apache/wicket/pull/682#discussion_r1379031758
##########
wicket-core/src/main/java/org/apache/wicket/settings/FrameworkSettings.java:
##########
@@ -68,7 +88,7 @@ public FrameworkSettings(final Application application)
* Gets the Wicket version. The Wicket version is in the same format as
the version element in
* the pom.xml file (project descriptor). The version is generated by
maven in the build/release
* cycle and put in the /META-INF/MANIFEST.MF file located in the root
folder of the Wicket jar.
- *
+ * <p></p>
Review Comment:
Most probably you want the closing `</p>` to be at the end of the paragraph.
##########
wicket-core/src/main/java/org/apache/wicket/settings/FrameworkSettings.java:
##########
@@ -129,26 +149,30 @@ public FrameworkSettings add(IEventDispatcher dispatcher)
return this;
}
+ /**
+ * @return Returns <code>true</code> if there is at least one event
dispatcher
+ */
+ public final boolean hasAnyAnyEventDispatchers()
Review Comment:
one too many `any`
##########
wicket-core/src/main/java/org/apache/wicket/settings/FrameworkSettings.java:
##########
@@ -45,8 +45,28 @@
*/
public class FrameworkSettings implements IEventDispatcher
{
+ /**
+ * Does the standard delivery of events. Override and do nothing if
you want to disable it.
Review Comment:
Since it is `private` it is not possible to `override` it
> [Events] make default events delivery machinery pluggable and roll usable
> annotation based one
> ----------------------------------------------------------------------------------------------
>
> Key: WICKET-7080
> URL: https://issues.apache.org/jira/browse/WICKET-7080
> Project: Wicket
> Issue Type: Improvement
> Components: events
> Reporter: Ernesto Reinaldo Barreiro
> Assignee: Ernesto Reinaldo Barreiro
> Priority: Major
> Fix For: 9.16.0, 10.0.0-M3
>
>
> [Events] make default events delivery machinery pluggable and roll usable
> annotation based one
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
