[
https://issues.apache.org/jira/browse/WICKET-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803305#comment-17803305
]
ASF GitHub Bot commented on WICKET-7090:
----------------------------------------
mattrpav commented on code in PR #758:
URL: https://github.com/apache/wicket/pull/758#discussion_r1442183475
##########
pom.xml:
##########
@@ -129,6 +129,8 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+
<project.build.outputTimestamp>2024-01-01T00:00:00Z</project.build.outputTimestamp>
Review Comment:
Using a static value seems difficult to manage. I suggest looking at using
the git commit timestamp.
Benefits:
1. Automatically changes
2. Changes with every commit
3. Ensures reproducible builds get the same timestamp when rebuilt from any
commit.
> Files in release jars do not have a modification timestamp set
> --------------------------------------------------------------
>
> Key: WICKET-7090
> URL: https://issues.apache.org/jira/browse/WICKET-7090
> Project: Wicket
> Issue Type: Bug
> Components: release
> Affects Versions: 9.8.0, 9.9.0, 9.10.0, 9.11.0, 9.12.0, 9.13.0, 9.14.0,
> 9.15.0, 9.16.0
> Reporter: Emond Papegaaij
> Assignee: Emond Papegaaij
> Priority: Minor
>
> Starting with 9.8.0, the release jars are built with file entries without a
> last modification timestamp. This can cause issues if
> {{LastModifiedResourceVersion}} used for the {{{}resourceCachingStrategy{}}}.
> The browser may be using an older version of the resource, even if a newer
> version is available. This strategy is normally only used in development
> mode, but even then this can cause unexpected behavior.
> As discussed on the dev list, the best we can do is to set the last
> modification timestamp to fixed time during the release, as git doesn't track
> this. A suggestion is to use the project.build.outputTimestamp property:
> https://maven.apache.org/guides/mini/guide-reproducible-builds.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
