[
https://issues.apache.org/jira/browse/WICKET-7105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839496#comment-17839496
]
ASF subversion and git services commented on WICKET-7105:
---------------------------------------------------------
Commit 3a881e01a42eb5840189cb78b7cb3d4b488ffaf2 in wicket's branch
refs/heads/master from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=3a881e01a4 ]
WICKET-7105: Remove 'final' from
AbstractPartialPageRequestHandler#add(Component...)
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
> Remove 'final' from AbstractPartialPageRequestHandler#add(Component...)
> -----------------------------------------------------------------------
>
> Key: WICKET-7105
> URL: https://issues.apache.org/jira/browse/WICKET-7105
> Project: Wicket
> Issue Type: Wish
> Reporter: Sven T
> Priority: Major
>
> We are currently in the progress of migrating a Wicket based framework from
> Wicket 8 to Wicket 10. Wicket 9 introduced a breaking change in
> AjaxRequestHandler, which made the method
> AjaxRequestHandler#add(Component...) *final* (within this change the method
> was moved to new parent class AbstractPartialPageRequestHandler. See [Commit
> in
> GitHub|https://github.com/apache/wicket/commit/2dc9bd121c62aab1b742e55ce9c2675a8439f6df#diff-6c297de222deaef2b5afc7a03fa8b058c45cc92127b0fae647f27bd35cb17a29L219]
>
> Is there any chance that the modifier can be removed again to match its
> previous state? We are currently overriding the add(Component...) method in
> Wicket 8 to add some custom logic to the refresh mechanism, which leads to
> compile errors while migrating to Wicket 9/10.
>
> If it helps, we could provide a pull request. Thanks in advance :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
