reiern70 commented on code in PR #846:
URL: https://github.com/apache/wicket/pull/846#discussion_r1595398663


##########
wicket-core/src/main/java/org/apache/wicket/csp/CSPRequestCycleListener.java:
##########
@@ -39,14 +40,7 @@ public CSPRequestCycleListener(ContentSecurityPolicySettings 
settings)
        }
 
        @Override
-       public void onRequestHandlerResolved(RequestCycle cycle, 
IRequestHandler handler)
-       {
-               // WICKET-7028- this is needed for redirect to buffer use case.
-               protect(cycle, handler);
-       }
-
-       @Override
-       public void onRequestHandlerExecuted(RequestCycle cycle, 
IRequestHandler handler)
+       public void onUrlMapped(RequestCycle cycle, IRequestHandler handler, 
Url url)

Review Comment:
   I have tried this with 
   
   https://issues.apache.org/jira/browse/WICKET-7028
   
   sample application and this change seems to be Ok. But to be honest I'm not 
sure this is the way we should go.  See 
   
   https://issues.apache.org/jira/browse/WICKET-7040
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to