martin-g commented on code in PR #928:
URL: https://github.com/apache/wicket/pull/928#discussion_r1689428603
##########
wicket-core/src/main/java/org/apache/wicket/core/request/handler/ListenerInvocationNotAllowedException.java:
##########
@@ -52,7 +52,8 @@ private static String detail(Component component,
StringBuilder detail = new StringBuilder("Component:
").append(component.toString(false));
if (behavior != null)
{
- detail.append(" Behavior:
").append(behavior.toString());
+ detail.append(" Behavior: ").append(behavior);
+ detail.append(" Path: ").append(component.getPath());
Review Comment:
Should this be in the if?
##########
wicket-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java:
##########
@@ -372,9 +372,7 @@ protected IRequestHandler handleException(final Exception e)
* Call out the fact that we are processing an
exception in a loud way, helps to notice
* them when developing even if they get wrapped or
processed in a custom handler.
*/
- logExtra.warn("********************************");
- logExtra.warn("Handling the following exception", e);
- logExtra.warn("********************************");
+ logExtra.warn("###***===--- Handling the following
exception ---===***###", e);
Review Comment:
What's the problem with the asterisks in Kafka aggregators?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
