[ 
https://issues.apache.org/jira/browse/WICKET-7126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martin Tzvetanov Grigorov updated WICKET-7126:
----------------------------------------------
    Description: 
Suggested improvements to the next version life cycle.

Context: the new cdi-unit tests are working only outside the wicket-cdi 
project. This seams to be related to the project being a Java Platform Module 
(removing the module-info.java file causes the tests to work OK again).

Improvement: to move the wicket-cdi tests to its module (wicket-cdi-tests)

Context: given the multiple options there are to create a BeanManager, I think 
it would be better to delegate to Wicket users what instance should be used 
instead of encapsulating this logic inside BeanManagerLookup.

Improvement:

 - to require the BeanManager at CdiConfiguration's constructor

 - rename BeanManagerLookup to JNDIBeanManagerLookup and simplify it by looking 
for BeanManager only in the JNDI context.
 - to remove the BeanManagerLookup lastSuccessful state

 - to remove the CdiConfiguration.set/getFallbackBeanManager and its related 
logic

  was:
Suggested improvements to the next version life cycle.

Context: the new cdi-unit tests are working only outside the wicket-cdi 
project. This seams to be related to the project being a Java Platform Module 
(removing the module-info.java file causes the tests to work OK again).

Improvement: to move the wicket-cdi tests to its module (wicket-cdi-test)

Context: given the multiple options there are to create a BeanManager, I think 
it would be better to delegate to Wicket users what instance should be used 
instead of encapsulating this logic inside BeanManagerLookup.

Improvement:

 - to require the BeanManager at CdiConfiguration's constructor

 - rename BeanManagerLookup to JNDIBeanManagerLookup and simplify it by looking 
for BeanManager only in the JNDI context.

- to remove the BeanManagerLookup lastSuccessful state

- to remove the CdiConfiguration.set/getFallbackBeanManager and its related 
logic


> To move wicket-cdi tests to its own module and CdiConfiguration new API
> -----------------------------------------------------------------------
>
>                 Key: WICKET-7126
>                 URL: https://issues.apache.org/jira/browse/WICKET-7126
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-cdi
>            Reporter: Pedro Henrique Oliveira dos Santos
>            Priority: Minor
>
> Suggested improvements to the next version life cycle.
> Context: the new cdi-unit tests are working only outside the wicket-cdi 
> project. This seams to be related to the project being a Java Platform Module 
> (removing the module-info.java file causes the tests to work OK again).
> Improvement: to move the wicket-cdi tests to its module (wicket-cdi-tests)
> Context: given the multiple options there are to create a BeanManager, I 
> think it would be better to delegate to Wicket users what instance should be 
> used instead of encapsulating this logic inside BeanManagerLookup.
> Improvement:
>  - to require the BeanManager at CdiConfiguration's constructor
>  - rename BeanManagerLookup to JNDIBeanManagerLookup and simplify it by 
> looking for BeanManager only in the JNDI context.
>  - to remove the BeanManagerLookup lastSuccessful state
>  - to remove the CdiConfiguration.set/getFallbackBeanManager and its related 
> logic



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to