[ 
https://issues.apache.org/jira/browse/WICKET-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894857#comment-17894857
 ] 

ASF subversion and git services commented on WICKET-7024:
---------------------------------------------------------

Commit 1ec7cf9eca9c6ed4082d30677ec455cd930215c6 in wicket's branch 
refs/heads/master from Pedro Santos
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=1ec7cf9eca ]

WICKET-7024 decode PackageResourceReference URL attributes only inside requests 
for it


> Wrong static resource urls when their generation is triggered by <wicket:link>
> ------------------------------------------------------------------------------
>
>                 Key: WICKET-7024
>                 URL: https://issues.apache.org/jira/browse/WICKET-7024
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 9.12.0
>            Reporter: Martin Tzvetanov Grigorov
>            Priority: Major
>         Attachments: wicket-link-leak.tgz
>
>
> If an application uses <wicket:link> to generate a url for a static resource, 
> e.g.
> {code:java}
> <html xmlns="http://www.w3.org/1999/xhtml"; 
> xmlns:wicket="http://wicket.apache.org/";>
> <head>
> <wicket:head>
>   <wicket:link>
>     <link rel="stylesheet" type="text/css" href="css/test2.css"  />
>   </wicket:link>
> </wicket:head>
> </head>
> ...  {code}
> then during the page render time it will use
> {code:java}
> CharSequence url = getRequestCycle().urlFor(handler); {code}
> and 
> [https://github.com/apache/wicket/blob/bc70f127ff74f154890a35be906b55db5bdc8683/wicket-core/src/main/java/org/apache/wicket/request/resource/PackageResourceReference.java#L117-L128]
>  will use the current page's url and try to parse locale/style/variation from 
> it and embed it in the static resource url.
> The problem is that it uses the pageId/renderCount/behaviorId and component 
> path instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to