[ 
https://issues.apache.org/jira/browse/WICKET-7133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900026#comment-17900026
 ] 

ASF GitHub Bot commented on WICKET-7133:
----------------------------------------

martin-g commented on code in PR #1041:
URL: https://github.com/apache/wicket/pull/1041#discussion_r1851960217


##########
wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/AutoCompleteSettings.java:
##########
@@ -379,4 +381,30 @@ public AutoCompleteSettings setMinInputLength(int 
minInputLength)
                this.minInputLength = minInputLength;
                return this;
        }
+
+       /**
+        * Indicates how the Tab key should be handled when having an item in 
the autocomplete list
+        * selected.
+        *
+        * @return <code>true</code> if the focus should return to the input 
field, <code>false</code>
+        * moves the focus to the next component.
+        */
+       public boolean shouldFocusInputOnTabSelection()

Review Comment:
   IMO it would be better to use an enum here instead of boolean.
   This way it would be:
   1) more clear what the values mean
   2) easier to add more values/states later
   





> Ability move focus back to the autocomplete field when selecting an item 
> using the Tab key
> ------------------------------------------------------------------------------------------
>
>                 Key: WICKET-7133
>                 URL: https://issues.apache.org/jira/browse/WICKET-7133
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>            Reporter: Erik Strid
>            Priority: Major
>         Attachments: myproject-tab-focus.zip
>
>
> We need the ability to prevent the autocomplete from moving the focus to the 
> next component when the user press "Tab". The marked item should be selected 
> but the focus should go back to the autocomplete input field.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to