theigl commented on code in PR #1076:
URL: https://github.com/apache/wicket/pull/1076#discussion_r1914609818
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -1273,9 +1273,11 @@ protected void
addDefaultSubmitButtonHandler(IHeaderResponse headerResponse)
String submitId = component.getMarkupId();
AppendingStringBuffer script = new AppendingStringBuffer();
- script.append("var b =
document.getElementById('").append(submitId).append("');");
- script.append("if (window.getComputedStyle(b).visibility ===
'hidden') return;");
- script.append("if (event.which == 13) {");
+ script.append("if (event.which != 13) return true;");
+ // text area will submit on CTRL+Enter
+ script.append("if (event.target.tagName.toLowerCase() ===
'textarea' && !event.ctrlKey) return true;");
Review Comment:
I don't think this is enough. I'm pretty sure we should to the same for
`contenteditable` elements used by most WYSIWYG editors. How was form submit
prevented for these elements before you submitted your original PR?
##########
wicket-core-tests/src/test/java/org/apache/wicket/markup/html/form/FormHierarchyDefaultButtonTestPage.java:
##########
@@ -33,6 +33,8 @@ public class FormHierarchyDefaultButtonTestPage extends
WebPage {
public final Button childSubmit;
public final TextField<?> parentInput;
public final TextField<?> childInput;
+ public final TextArea<?> parentTextarea;
+ public final TextArea<?> childTextarea;
Review Comment:
Please fix the indentation here and also in the HTML files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
