[
https://issues.apache.org/jira/browse/WICKET-7145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922754#comment-17922754
]
ASF GitHub Bot commented on WICKET-7145:
----------------------------------------
mattrpav commented on code in PR #1093:
URL: https://github.com/apache/wicket/pull/1093#discussion_r1937528474
##########
wicket-core/src/main/java/org/apache/wicket/application/CompoundClassResolver.java:
##########
@@ -153,4 +155,4 @@ public CompoundClassResolver remove(final IClassResolver
resolver)
resolvers.remove(resolver);
return this;
}
-}
\ No newline at end of file
+}
Review Comment:
Code style EOF new line?
##########
wicket-core-tests/src/test/java/org/apache/wicket/core/request/mapper/BasicResourceReferenceMapperTest.java:
##########
@@ -47,6 +45,10 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
Review Comment:
static imports usually come before non-static?
##########
wicket-core/src/main/java/org/apache/wicket/ajax/attributes/ThrottlingSettings.java:
##########
@@ -131,4 +133,4 @@ public void setPostponeTimerOnUpdate(boolean
postponeTimerOnUpdate)
this.postponeTimerOnUpdate = postponeTimerOnUpdate;
}
-}
\ No newline at end of file
+}
Review Comment:
Does the Wicket code style call for newline or no newline at end of file?
##########
wicket-core/src/main/java/org/apache/wicket/application/IClassResolver.java:
##########
@@ -45,12 +47,12 @@ public interface IClassResolver
* @param name
* @return iterator over matching resources
*/
- Iterator<URL> getResources(String name);
+ Iterator<URL> getResources(@Nonnull String name);
/**
* Returns the {@link ClassLoader} to be used for resolving classes
*
* @return the {@link ClassLoader} to be used for resolving classes
*/
ClassLoader getClassLoader();
-}
\ No newline at end of file
+}
Review Comment:
Code style EOF new line?
##########
wicket-core/src/main/java/org/apache/wicket/core/util/crypt/AESCrypt.java:
##########
@@ -129,4 +131,4 @@ protected byte[] encrypt(byte[] plainBytes)
}
}
-}
\ No newline at end of file
+}
Review Comment:
Code style EOF new line?
##########
wicket-guice/src/test/java/org/apache/wicket/guice/JakartaInjectTestBehavior.java:
##########
@@ -16,13 +16,14 @@
*/
package org.apache.wicket.guice;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-
import jakarta.inject.Inject;
import org.apache.wicket.Component;
import org.apache.wicket.behavior.Behavior;
+import javax.annotation.Nonnull;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
Review Comment:
static imports first?
##########
wicket-native-websocket/wicket-native-websocket-core/pom.xml:
##########
@@ -34,6 +34,10 @@
<osgi.import.package>!java*,!kotlin*,!sun.nio.ch,org.slf4j*;version="[1.7,3)",*</osgi.import.package>
</properties>
<dependencies>
+ <dependency>
+ <groupId>jakarta.annotation</groupId>
+ <artifactId>jakarta.annotation-api</artifactId>
+ </dependency>
<dependency>
Review Comment:
Good time to fix the wicket-native-websocket-core/pom.xml formatting?
##########
wicket-core/src/main/java/org/apache/wicket/markup/repeater/data/GridView.java:
##########
@@ -335,4 +337,4 @@ private void findNext()
}
}
-}
\ No newline at end of file
+}
Review Comment:
Code style EOF new line?
> Developer experience improvement: nullability
> ---------------------------------------------
>
> Key: WICKET-7145
> URL: https://issues.apache.org/jira/browse/WICKET-7145
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 10.4.0
> Reporter: Johan Stuyts
> Priority: Minor
> Attachments: WICKET-7145.patch
>
>
> Knowing whether a variable can be {{null}} or not, improves the developer
> experience. A first step is to add {{@Nonnull}} to parameters that are
> checked for {{{}null{}}}.
> The patch adds {{@Nonull }}to those parameters. The following has been done:
> * The annotation has been added to base and sub types, and to some overloads.
> * Conditional nullability has been taken into account.
> ** In some methods in {{Files}} the client may pass values for other
> parameters that allows the non-{{{}null{}}} parameter to be {{{}null{}}}. It
> is assumed that clients do not do this. If a client checks if the
> non-{{{}null{}}} parameter may be {{{}null{}}}, the client can better skip
> the call.
> In some hierarchies the handling of {{null}} is inconsistent. The contract of
> the base method has to be tightened, or the implementations need to be
> changed to support {{{}null{}}}:
> * {{{}org.apache.wicket.request.Response.encodeURL{}}}: the annotations has
> only be added to the implementations in {{ServletWebResponse}} and
> {{{}WebSocketResponse{}}}.
> * {{{}org.apache.wicket.request.http.WebResponse.encodeRedirectURL{}}}: the
> same holds true as above.
> *
> {{{}org.apache.wicket.request.mapper.parameter.IPageParametersEncoder.encodePageParameters{}}}:
> the annotation has only be added to the implementation in
> {{{}UrlPathPageParametersEncoder{}}}.
> In addition bugs were found and fixed:
> * The order of the parameters to {{Checks.notNull(...)}} in
> {{{}OriginResourceIsolationPolicy{}}}.
> * The order of parameters to {{assertNull(...)}} in {{BaseWicketTester}} and
> {{{}WicketTesterTest{}}}.
> The patch is quite big, but the changes are small and simple. The changes can
> be viewed here:
> https://github.com/apache/wicket/compare/master...jstuyts:wicket:add-non-null-to-parameters
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
