[
https://issues.apache.org/jira/browse/WICKET-7090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18030660#comment-18030660
]
ASF GitHub Bot commented on WICKET-7090:
----------------------------------------
bgooren commented on code in PR #1278:
URL: https://github.com/apache/wicket/pull/1278#discussion_r2440326125
##########
wicket-auth-roles/pom.xml:
##########
@@ -24,7 +24,7 @@
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-auth-roles</artifactId>
- <packaging>bundle</packaging>
+ <packaging>jar</packaging>
Review Comment:
I agree that it's rather strange that this is affecting the (non-) inclusion
of a minified javascript file.
But alas I am not an expert on the inner workings of the various maven
resources plugins. As can be seen in my wicket issue I did try to dig into this
a bit, but for some reason it simply is not included - even with debug logging
there is no indication of anything that might cause this.
@solomax simply experimented a bit, I think, and found that this change
affects the inclusion of the min.js file. Then I simply looked at the git blame
data to see which commit(s) made that change on main.
Of course I would also like to know what is the root cause here; But it will
take time and some knowledge of the maven plugins used. I'm willing to spend
some time on this, but do not know how to debug this properly.
After developing some maven plugins I found it's quite hard to debug them in
a live project.
> Files in release jars do not have a modification timestamp set
> --------------------------------------------------------------
>
> Key: WICKET-7090
> URL: https://issues.apache.org/jira/browse/WICKET-7090
> Project: Wicket
> Issue Type: Bug
> Components: release
> Affects Versions: 9.8.0, 9.9.0, 9.10.0, 9.11.0, 9.12.0, 9.13.0, 9.14.0,
> 9.15.0, 9.16.0
> Reporter: Emond Papegaaij
> Assignee: Emond Papegaaij
> Priority: Minor
> Fix For: 10.0.0
>
>
> Starting with 9.8.0, the release jars are built with file entries without a
> last modification timestamp. This can cause issues if
> {{LastModifiedResourceVersion}} used for the {{{}resourceCachingStrategy{}}}.
> The browser may be using an older version of the resource, even if a newer
> version is available. This strategy is normally only used in development
> mode, but even then this can cause unexpected behavior.
> As discussed on the dev list, the best we can do is to set the last
> modification timestamp to fixed time during the release, as git doesn't track
> this. A suggestion is to use the project.build.outputTimestamp property:
> https://maven.apache.org/guides/mini/guide-reproducible-builds.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
