bgooren commented on code in PR #1278:
URL: https://github.com/apache/wicket/pull/1278#discussion_r2440326125
##########
wicket-auth-roles/pom.xml:
##########
@@ -24,7 +24,7 @@
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>wicket-auth-roles</artifactId>
- <packaging>bundle</packaging>
+ <packaging>jar</packaging>
Review Comment:
I agree that it's rather strange that this is affecting the (non-) inclusion
of a minified javascript file.
But alas I am not an expert on the inner workings of the various maven
resources plugins. As can be seen in my wicket issue I did try to dig into this
a bit, but for some reason it simply is not included - even with debug logging
there is no indication of anything that might cause this.
@solomax simply experimented a bit, I think, and found that this change
affects the inclusion of the min.js file. Then I simply looked at the git blame
data to see which commit(s) made that change on main.
Of course I would also like to know what is the root cause here; But it will
take time and some knowledge of the maven plugins used. I'm willing to spend
some time on this, but do not know how to debug this properly.
After developing some maven plugins I found it's quite hard to debug them in
a live project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
