[
https://issues.apache.org/jira/browse/WICKET-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18050317#comment-18050317
]
ASF GitHub Bot commented on WICKET-7172:
----------------------------------------
keesvandieren commented on code in PR #1341:
URL: https://github.com/apache/wicket/pull/1341#discussion_r2667453396
##########
wicket-core/src/main/java/org/apache/wicket/csp/CSPDirective.java:
##########
@@ -147,6 +151,19 @@ public String getValue()
public void checkValueForDirective(CSPRenderable value,
List<CSPRenderable> existingDirectiveValues)
{
+ if (this == SCRIPT_SRC_ATTR || this == STYLE_SRC_ATTR)
+ {
+ if (!existingDirectiveValues.isEmpty())
+ {
+ throw new IllegalArgumentException("Directive "
+ this + " supports only one value");
Review Comment:
Actually you are correct, my implementation doesn't support all allowed
values. These should be allowed:
'none'
'unsafe-hashes'
'unsafe-inline'
'report-sample'
> Support new CSP style, script directives
> ----------------------------------------
>
> Key: WICKET-7172
> URL: https://issues.apache.org/jira/browse/WICKET-7172
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Reporter: Kees van Dieren
> Priority: Major
>
> Support new CSP directives added to the CSP in 2022
> They where not yet supported by Wicket.
> See: https://github.com/apache/wicket/pull/1341
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
