weber-semedy opened a new pull request, #1356: URL: https://github.com/apache/wicket/pull/1356
Changes for WICKET-7162 (https://github.com/apache/wicket/pull/1223) removed a null check for `httpSession`, leading to another NPE when trying to add `httpSession` to the `userProperties` map ``` SEVERE [...] org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for servlet [default] in context with path [/contextpath] threw exception [java.lang.NullPointerException] with root cause java.lang.NullPointerException at java.base/java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011) at java.base/java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006) at org.apache.wicket.protocol.ws.javax.WicketServerEndpointConfig$JavaxWebSocketConfigurator.modifyHandshake(WicketServerEndpointConfig.java:146) at org.apache.tomcat.websocket.server.UpgradeUtil.doUpgrade(UpgradeUtil.java:210) at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:78) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109) at org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:293) ``` I requested a Jira account to file a new issue and retrieve the id. NOTE: We will still see the valid (follow-up) exception when `httpSession` is `null`: ``` org.apache.coyote.AbstractProtocol$ConnectionHandler.process Error reading request, ignored java.lang.IllegalStateException: There is no HTTP Session bound. Without a session Wicket won't be able to find the stored page to update its components at org.apache.wicket.protocol.ws.api.AbstractWebSocketProcessor.<init>(AbstractWebSocketProcessor.java:111) at org.apache.wicket.protocol.ws.javax.JavaxWebSocketProcessor.<init>(JavaxWebSocketProcessor.java:48) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
