[
https://issues.apache.org/jira/browse/WICKET-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18073106#comment-18073106
]
ASF GitHub Bot commented on WICKET-7179:
----------------------------------------
martin-g commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3071896906
##########
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js:
##########
@@ -652,14 +652,14 @@
var scName = attrs.sc;
data = data.concat({name: scName,
value: 1});
}
- } else if (attrs.c && !jQuery.isWindow(attrs.c)) {
+ } else if (attrs.c != null && !(attrs.c ===
attrs.c.window)) {
Review Comment:
```suggestion
} else if (attrs.c !== null && attrs.c !==
attrs.c.window) {
```
##########
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js:
##########
@@ -443,7 +443,7 @@
var target;
if (attrs.event) {
target = attrs.event.target;
- } else if (!jQuery.isWindow(attrs.c)) {
+ } else if (attrs.c != null && !(attrs.c ===
attrs.c.window)) {
Review Comment:
```suggestion
} else if (attrs.c !== null && attrs.c !==
attrs.c.window) {
```
> add support for jQuery 4.0.0
> ----------------------------
>
> Key: WICKET-7179
> URL: https://issues.apache.org/jira/browse/WICKET-7179
> Project: Wicket
> Issue Type: Improvement
> Reporter: Ernesto Reinaldo Barreiro
> Assignee: Ernesto Reinaldo Barreiro
> Priority: Major
>
> add support for jQuery 4.0.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
