martin-g commented on code in PR #1493:
URL: https://github.com/apache/wicket/pull/1493#discussion_r3453590515
##########
wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestHandler.java:
##########
@@ -104,7 +104,18 @@ public AjaxRequestHandler(final Page page)
{
super(page);
- update = new XmlPartialPageUpdate(page)
+ update = newPartialPageUpdate(page);
Review Comment:
https://stackoverflow.com/questions/3404301/whats-wrong-with-overridable-method-calls-in-constructors
It will be better to add another constructor `public
AjaxRequestHandler(final Page page, final PartialPageUpdate ppu)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
