bitstorm commented on PR #1498: URL: https://github.com/apache/wicket/pull/1498#issuecomment-4877696316
@jstuyts hi see the point. The PR looks good to me but as I mentioned in the previous comment I would apply this "as is" to the wicket-10.x branch, while I think we might rework it for branch master where compatibility constraints don't apply. What do you think if we use class JavaScriptHeaderItem as target base class for type field? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
