[ 
https://issues.apache.org/jira/browse/WICKET-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18094915#comment-18094915
 ] 

ASF GitHub Bot commented on WICKET-7187:
----------------------------------------

bitstorm commented on code in PR #1498:
URL: https://github.com/apache/wicket/pull/1498#discussion_r3528201880


##########
wicket-core/src/main/java/org/apache/wicket/markup/head/JavaScriptDataBlockType.java:
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.markup.head;
+
+import java.util.Locale;
+import java.util.Set;
+import java.util.regex.Pattern;
+
+import org.apache.wicket.util.lang.Args;
+
+/**
+ * A <a 
href="https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type#value";>data
 block</a>

Review Comment:
   Is this the correct URL or shall we use 
'https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/MIME_types#textjavascript'
 also here?





> JavaScript header items: `module` for content, and import maps
> --------------------------------------------------------------
>
>                 Key: WICKET-7187
>                 URL: https://issues.apache.org/jira/browse/WICKET-7187
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>            Reporter: Johan Stuyts
>            Priority: Major
>
> A number of JavaScript components has stopped providing 
> [UMD|https://github.com/umdjs/umd] builds, and provide [ECMAScript 
> modules|https://tc39.es/ecma262/#sec-modules] instead. To be able to use 
> those modules, JavaScript in the header must also be a module. But currently 
> it is not possible to specify the type for 
> {{{}JavaScriptContentHeaderItem{}}}.
> Additionally, modules use "[bare 
> modules|https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type/importmap#bare_modules]";
>  to import dependencies, and these bare modules need to be mapped to the URLs 
> of resource references so the JavaScript can be loaded.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to