timtebeek commented on PR #1557: URL: https://github.com/apache/wicket/pull/1557#issuecomment-6060827930
> Thanks for your quick response, @timtebeek ! Of course, trying to help as best I can. > So, OSS modules depend on paid ones and the users have to figure it out... No we very strictly only have dependencies pointing from proprietary & source available modules to the Apache licensed modules. None of that has changed; the modules you're depending on just aren't Apache licensed, but were on Maven Central all the same. You can see the full list of licensed on https://docs.openrewrite.org/reference/latest-versions-of-every-openrewrite-module > > I've added exclusions for the problematic modules and now the build fails with dependency convergence errors: Hmm, that listing shows you still use `rewrite-migrate-java: 3.26.0 `, which itself also falls under MSAL, and has fallen behind even by what was last pushed to central: https://mvnrepository.com/artifact/org.openrewrite.recipe/rewrite-migrate-java > Lately a LLM agent does pretty good job in helping with migrations, so based on the problems above my opinion is that wicket-migration module should be removed for Wicket 11 and documented as deprecated for Wicket 10. While I can't stop you there, I can say from our experience users will have the best results (in terms of performance, costs, and predicability) when doing as much as possible in a deterministic way, before handing off to LLMs. Something to consider, as these types of changes are mechanical: https://github.com/apache/wicket/blob/003cf99a60c641c9225665e008b368d2de9aa29f/wicket-migration/src/main/resources/META-INF/rewrite/wicket.yml#L98-L126 If you still choose to drop the module I'd understand; thanks for working with us so far and all the best going forward. ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
