reiern70 commented on code in PR #1672: URL: https://github.com/apache/wicket/pull/1672#discussion_r4300825689
########## wicket-core-tests/src/test/java/org/apache/wicket/request/resource/AbstractResourceRangeHeaderTest.java: ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.wicket.request.resource; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; + +import java.nio.charset.StandardCharsets; + +import org.apache.wicket.request.Response; +import org.apache.wicket.request.cycle.RequestCycle; +import org.apache.wicket.util.tester.WicketTestCase; +import org.junit.jupiter.api.Test; + +/** + * Tests that a Range header with a malformed value does not fail the resource request, and that a + * well-formed value is still picked up. + */ +class AbstractResourceRangeHeaderTest extends WicketTestCase +{ + private static final String DATA = "0123456789"; + + private Long start; + + private Long end; + + /** + * A resource that records the content range meta data seen by the request cycle while its + * data is written. + */ + private ByteArrayResource newRecordingResource() + { + return new ByteArrayResource("application/octet-stream", DATA.getBytes(StandardCharsets.US_ASCII)) Review Comment: 106 columns; the project wraps at 100. Moot if the cases move into `PackageResourceReferenceTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
