archiforge opened a new pull request, #1687: URL: https://github.com/apache/wicket/pull/1687
This back-ports the `XsltTransformer` hardening from master (348725cf, PR #1537) to the 8.x line, as requested in WICKET-7201. - `XsltTransformer.transform()` now enables `XMLConstants.FEATURE_SECURE_PROCESSING` on its `TransformerFactory`, matching `XSLTResourceStream` on this line. - Adds the upstream XXE regression test, adapted to this line's JUnit 4 test generation, to `wicket-core`. - Does not set `accessExternalDTD`/`accessExternalStylesheet` (the JDK transformer implies both under the feature) and does not change the caller-supplied-factory constructor of `XSLTResourceStream`, per the ticket. Regression evidence: the new test fails on this branch without the source change (the canary is resolved into `<r>WICKET-XXE-CANARY-7f55</r>`) and passes with it, alongside `OutputTransformerContainerTest` (3/3). `mvn -Pfast -pl wicket-core -am test -Dtest=XsltTransformerXxeTest,OutputTransformerContainerTest -Dsurefire.failIfNoSpecifiedTests=false` on JDK 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
