dashorst opened a new pull request, #1691: URL: https://github.com/apache/wicket/pull/1691
Fixes #1690, a follow-up to #1684 (GitHub issue #1678). With `slf4j-simple` at test scope, `mvn jetty:run` on a generated quickstart had no SLF4J back end: the jetty-ee11-maven-plugin leaves test-scoped dependencies off the webapp classpath unless `useTestScope` is set. SLF4J fell back to the NOP logger and all of Wicket's logging was dropped. - `<useTestScope>true</useTestScope>` on the Jetty plugin, so `jetty:run` logs through `slf4j-simple` like `Start` does. - The comment on the dependency now says it only serves `Start`, `jetty:run` and the tests, and that a WAR deployed to a container without an SLF4J back end needs one added. Verified: - `mvn verify -pl archetypes/quickstart` passes, including the archetype integration test. - `mvn jetty:run` on the generated project logs `Started Wicket version 11.0.0-SNAPSHOT in DEVELOPMENT mode`, and `/` returns 200. Before this change it printed `No SLF4J providers were found`. - The WAR contains `slf4j-api` and no back end. Migration-guide note: a quickstart generated from 11.x no longer packages `slf4j-simple` in its WAR. When deploying to a container that has no SLF4J back end of its own (Tomcat, a standalone Jetty), add one as a runtime dependency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
