reiern70 opened a new pull request, #1697: URL: https://github.com/apache/wicket/pull/1697
Backport of #1695 to `wicket-10.x`, for GitHub issue #1676. - 4ced50796e, cherry-picked from #1695 with one conflict: 10.x builds the `BoundedInputStream` in `PartWriterCallback` with its constructor rather than the builder, so only the limit passed to it changes there. Otherwise it is the same change. A suffix range (`bytes=-5`) is served from the end instead of the start. A range starting at or past the end is answered with 416 and `Content-Range: bytes */<length>`. An invalid range (`bytes=20-10`, `bytes=-`) is ignored with 200, and the last byte in `Content-Range` is capped at the length. #1695 has the details and a before/after table. No signature changes: japicmp has nothing to report against 10.0.0. The values behind `CONTENT_RANGE_STARTBYTE` and `CONTENT_RANGE_ENDBYTE` do change, as described in #1695. The start is negative for a suffix range, and neither key is set for an invalid range. Applications that pass them to `PartWriterCallback`, as `PackageResource` and `FileSystemResource` do, need no change. The release notes of the next 10.x should mention it for code that reads them itself. Verified on this branch: - `PackageResourceReferenceTest` and `PartWriterCallbackTest` pass. - `mvn clean verify -Pjs-test` is green on JDK 17, japicmp included. This goes in after #1695. If #1695 changes in review, this branch gets the same change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
