dashorst opened a new pull request, #1701:
URL: https://github.com/apache/wicket/pull/1701
Part of #1699. `build-changelog.sh` now builds the release notes from both
Jira and GitHub. A release without a Jira version, such as 10.12.0, gets a
changelog section from its GitHub issues alone.
The old script was broken for every version: Jira's `ReleaseNote.jspa` page
answers anonymous requests with 401 now, so the version-id lookup always
failed. The Jira issues now come from the anonymous REST API (fix version,
resolution Fixed); a version Jira does not know is skipped.
Of the options in the issue, this takes the commit-based one. Nothing on
GitHub records the release yet, and milestones or labels would mean tagging
every issue for this release by hand first.
- **GitHub issues** are the ones referenced from the commits between the
previous `rel/wicket-*` tag and HEAD, as `#N`, `GH-N` or an issue URL. A
referenced pull request contributes the issues it closes. Issues closed as not
planned or as a duplicate are left out; open issues fixed on a maintenance
branch (#1584, #1659 on 10.x) are kept. `--since <ref>` overrides the start.
- **Groups** come from GitHub's issue types, which the Apache org already
defines: Bug, Feature (as `New Feature`, next to Jira's) and Task. An issue
without a type goes into `** Other`, and the script reports how many there are.
- **Keys** are `[GH-N]`. Otherwise the layout is unchanged, so `release.sh`
needs no change: it still reads `/tmp/release-notes-<version>.txt` or cuts the
section out of the changelog.
- **Missed fixes**: a fix whose commits do not reference its issue is not
found. Before committing, the script lists the issues closed as completed in
the same period that no commit on any branch references.
## Review
The only file is `build-changelog.sh`.
- `getGitHubIssues`: one GraphQL query per 50 numbers.
- `getReferencedGitHubIssues`: pulls the references out of the commit
messages.
- The main flow: choosing the range, the Jira query, the unreferenced check,
and the sort-and-format step.
The commit message has the full reasoning.
## Risk
Only release tooling changes; nothing in the build or the artifacts does.
The release manager now needs `jq` and a logged-in `gh`; the script checks for
both. It runs under bash, which it already needed through `function` and `[[`.
A fix tracked both in Jira and on GitHub appears twice: regenerating 10.10.0
lists WICKET-7189 and GH-1492, which is the same fix. That has to be removed by
hand.
## Tests
The script was run on each branch, at its own tip, with Enter pressed at
every prompt.
- **Jira section:** regenerating 10.10.0 from the commit before its
changelog commit gives the same Jira section as the original, byte for byte.
- **`release.sh` extraction:** its `awk` extraction reads the new 10.12.0
section correctly.
- **Shellcheck:** clean at `-S warning`.
The 19 untyped GitHub issues below would be grouped if their type were set
before the release run.
## Output on master (11.0.0)
`CHANGELOG-11.x` does not exist yet, so the script creates it.
```
Apache Wicket release notes generator
=====================================
This tool collects the issues resolved in the upcoming release from JIRA
and GitHub, and merges them with the existing CHANGELOG in a text format.
Version to collect the release notes for: 11.0.0
Commits searched for GitHub issues: rel/wicket-10.11.0..HEAD
Press <enter> to continue
Collecting the resolved issues -- making web requests
- retrieving JIRA issues fixed in 11.0.0: 18
- retrieving GitHub issues referenced since rel/wicket-10.11.0: 21
- checking for GitHub issues closed without a reference: 1
GitHub issues without an issue type: 19. They are listed under 'Other'; set
their type (Bug, Feature or Task) on GitHub and run this tool again to group
them.
These GitHub issues were closed as completed in the same period, but no
commit on
any branch references them, so they are not in the release notes. To add one
that was fixed
in this release, edit the changelog afterwards and amend the commit:
GH-1588 Vulnerable dependencies need to be updated
Press <enter> to continue, or Ctrl-C to stop - merging release notes into
changelog: done
diff --git a/CHANGELOG-11.x b/CHANGELOG-11.x
new file mode 100644
index 0000000000..19b8bd2506
--- /dev/null
+++ b/CHANGELOG-11.x
@@ -0,0 +1,63 @@
+This file contains all changes done in releases for Apache Wicket 11.x.
+
+=======================================================================
+
+Release Notes - Wicket - Version 11.0.0
+
+** Bug
+
+ * [WICKET-7107] - CSP Header not rendered when using
RedirectPolicy.AUTO_REDIRECT
+ * [WICKET-7182] - Wicket Autocomplete calls event on a non jquery object
+ * [WICKET-7186] - wicket 10.9.0 / 10.9.1 leaks File Reaper threads
+ * [WICKET-7189] - make partial page update creation pluggable.
+ * [GH-1616] - AsynchronousPageStoreTest.storeAsynchronousContextClosed
never observes its own assertions
+
+** New Feature
+
+ * [WICKET-7169] - Make partHeaderSizeMax in AbstractFileUpload
configurable
+ * [WICKET-7190] - Unified cryptography API
+ * [WICKET-7196] - Allow unescaped wicket:label tags
+ * [GH-1614] - Make LoadableDetachableModel#detach() final and add
detach hooks that receive the attached object
+
+** Improvement
+
+ * [WICKET-7135] - Work on deprecation warnings
+ * [WICKET-7172] - Support new CSP style, script directives
+ * [WICKET-7176] - Bump up CDI API and Weld versions
+ * [WICKET-7179] - add support for jQuery 4.0.0
+ * [WICKET-7184] - Make <wicket:header-items/> HTML spec compliant
+ * [WICKET-7187] - JavaScript header items: `module` for content, and
import maps
+ * [WICKET-7188] - Sign file upload resource constraints
+ * [WICKET-7192] - restrict SourcesPage to resources of the page's own
package
+ * [WICKET-7195] - Add tag type="search" to those supported by TextField
+
+** Task
+
+ * [WICKET-7193] - Deprecate and remove IAuthenticationStrategy
+ * [WICKET-7194] - Deprecate and remove Include
+
+** Other
+
+ * [GH-1492] - AjaxRequestHandler generation of PartialPageUpdate is not
extensible
+ * [GH-1576] - BUG since 10.11.0: Wrong escaping in Button label,while
getEscapeModelStrings=false
+ * [GH-1582] - build fails on SignOut
+ * [GH-1583] - create a version of wicket ajax and all the other
standard components that is jQuery independent.
+ * [GH-1584] - Redundant japicmp exclusions need to removed
+ * [GH-1593] - Typo in WARN message
+ * [GH-1618] - Palette "move up" broken since 10.9.0: moveUpHelper calls
box.trigger('focus') on a plain DOM element
+ * [GH-1620] - TrapFocusBehavior: Tab/Shift+Tab at trap boundary throws
TypeError on wicket-10.x
+ * [GH-1631] - Add Ajax veil behaviors that block the page, or a
component, while a request runs
+ * [GH-1646] - Wicket.Event.remove does not remove a listener added for
several event types
+ * [GH-1647] - The WebSocket charts example calls jQuery.parseJSON,
which jQuery 4 removed
+ * [GH-1650] - AjaxButton triggering the submit event also submits the
form in Firefox
+ * [GH-1658] - The quickstart archetype's Start.java does not compile
against Jetty 12
+ * [GH-1659] - CrossOrigin.USE_CREDENTIALS renders user-credentials
instead of use-credentials
+ * [GH-1669] - multiple file upload to resource + drag and drop files
and upload to resource.
+ * [GH-1670] - problems with upload to resource
+ * [GH-1678] - Quickstart archetype: give slf4j-simple test scope
+ * [GH-1688] - WebSocket: Request wrappers break the Servlet header
contract (case-sensitive lookup, single-use enumerations)
+ * [GH-1699] - Include GitHub issues in the release notes built by
build-changelog.sh
+
+=======================================================================
+
+
[detached HEAD b1ded3d6ae] Added CHANGELOG for release 11.0.0
1 file changed, 63 insertions(+)
create mode 100644 CHANGELOG-11.x
The CHANGELOG-11.x file has been updated and committed.
To revert the changes to the CHANGELOG:
git reset HEAD^ --hard
Have fun!
```
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
