papegaaij opened a new pull request, #1732:
URL: https://github.com/apache/wicket/pull/1732

   Part of #1723. Independent of #1731; together they leave Apache RAT with 
nothing to report.
   
   The Apache Trusted Releases platform (ATR) runs Apache RAT 0.18 on every 
source archive. Every unapproved file becomes a concern the release manager has 
to acknowledge before a vote. On master, RAT run with the ATR's arguments flags 
1470 files. This PR brings that to zero and keeps it there.
   
   ## What changes
   
   - **`.rat-excludes`** at the root. This is the file the ATR reads. It lists 
the files that stay without a header, grouped by reason:
     - third-party code, which `LICENSE` covers
     - generated release notes
     - IDE settings
     - the archetype's project templates
     - markup Wicket renders to the browser as is
     - example markup
     - test data that tests compare byte for byte
   
     The groups follow the ignore lists of the existing 
`ApacheLicenceHeaderTest`s.
   - **Headers added** to the files that can carry one:
     - the root markdown files and `.asf.yaml`
     - the `META-INF/services` files
     - the 222 user guide `.adoc` files (in `////` comments, which don't render)
     - a few XML and text files
     - two Java files that lacked one
   - **Root pom** runs `apache-rat-plugin` 0.18 at `validate`, over the whole 
tree, reading the same `.rat-excludes`.
     - Locally it also skips what Git ignores, `node`/`node_modules`, and 
minified files.
     - It takes about half a minute, so `-Pfast` skips it.
   
   ## Worth knowing
   
   - **Local files without a header now fail the build.** That applies to any 
file neither committed nor ignored by Git, such as a local note.
   - **The release needs no extra step.** `release:perform` builds from a clean 
checkout of the tag, so this check runs on exactly what goes into the archive.
   - **The ATR scans more than the local build.** With a `.rat-excludes` 
present, it drops its own Git/Maven/IDE default exclusions, which is why 
`.gitignore` and `MANIFEST.MF` are listed explicitly.
   
   ## Verification
   
   - `mvn clean verify -Pjs-test` passes.
   - A file without a header fails the build and is named in the output.
   - RAT 0.18 run with the ATR's exact arguments on a `git archive` reports 0 
unapproved files. That holds for this branch alone and merged with #1731.
   - The user guide still renders (`-Pguide`), with no header text in the HTML 
or DocBook output.
   
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to