dashorst opened a new pull request, #1750:
URL: https://github.com/apache/wicket/pull/1750

   ## Summary
   
   - Take the staging repository from the repositories that the deploy created, 
by comparing `rc-list` before and after `release:perform`, instead of taking 
the first open `orgapachewicket-*` in the list. Stop with a message unless 
exactly one was created. Fixes GitHub issue #1749.
   - Write the release changelog to a new `mktemp` file on every run, so a 
rerun no longer puts it twice into `release-vote.txt` and 
`release-announce.txt`. Fixes GitHub issue #1749.
   - Add `set -e` to the generated revert and promote scripts so they stop at 
the first failing step. `rm -f release.properties` replaces the `[ -f ] && rm` 
line, which would otherwise be the last command's exit status. Fixes GitHub 
issue #1749.
   - The listing in the revert script now reads `tail -n +15` because of the 
added `set -e` line.
   - A failed `rc-close` is now fatal, and so is a failed `rc-list`.
   - `fail` prints its message with `printf`, so the error colour is an escape 
sequence and not literal text.
   - The promote script's template is read with `read -r`, and its `svn rm` 
quotes are escaped once, so the commands it prints can be copied as they are.
   
   ## Testing
   
   - `bash -n release.sh` passes on each commit in the branch.
   - `shellcheck release.sh`: the only SC2162 warnings left are the two 
interactive `read` prompts (version and "press enter"), which read typed input.
   - Stubbed run with stub `mvn`, `git` and `svn` on the PATH: generated 
`promote-<version>.sh` and `revert-<version>.sh`. The promote script's closing 
message prints `git commit -m "Start next development version"` and `svn rm ... 
-m "Remove previous version from mirrors"` with the quotes intact. The revert 
script is unchanged by the `read -r` change.
   - `fail` with a message containing a backslash and a percent sign: the 
output is red and the message is printed unchanged, checked with `cat -v`.
   - Not run: staging repository selection against real `rc-list` output, and a 
full `release.sh` run, which deploys to Nexus and dist.apache.org.
   - Not run: `mvn clean verify`. The change touches only `release.sh`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to