This is an automated email from the ASF dual-hosted git repository.

dashorst pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git

commit 3069021f5b0a861040cd03e18e342df38fcba76b
Author: Martijn Dashorst <[email protected]>
AuthorDate: Sun Nov 1 13:36:32 2026 +0100

    Write the release changelog to a fresh file on every run of release.sh
    
    generate_signatures_from_release appended the changelog to
    /tmp/release-$version-sigs.txt, and nothing emptied or removed that
    file. Running release.sh a second time for the same version, after a
    revert, appended a second copy, so release-vote.txt and
    release-announce.txt listed the whole changelog twice.
    
    The changelog is now written to a new mktemp file on every run, so a
    previous run of the same version leaves nothing behind that ends up in
    the mails, whether or not the revert cleaned up. The file no longer has
    a fixed name in /tmp; nothing outside release.sh read it.
    
    GitHub issue #1749
    
    Generated-by: Claude Code (Claude Opus 5.5)
---
 release.sh | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/release.sh b/release.sh
index e8f44b9143..58183576df 100755
--- a/release.sh
+++ b/release.sh
@@ -138,15 +138,18 @@ echo "$script" > revert-$version.sh
 
 function generate_signatures_from_release {
 
+    sigs=$(mktemp "${TMPDIR:-/tmp}/release-$version-sigs.XXXXXX") \
+        || fail "Unable to create a temporary file for the changelog of 
$version"
+
     echo 
"========================================================================
 
     CHANGELOG for $version:
-    " >> /tmp/release-$version-sigs.txt
+    " > "$sigs"
 
     if [ -f "/tmp/release-notes-$version.txt" ] ; then
-        tail -n +4 /tmp/release-notes-$version.txt >> 
/tmp/release-$version-sigs.txt
+        tail -n +4 /tmp/release-notes-$version.txt >> "$sigs"
     else
-        awk "/Release Notes - Wicket - Version $version/{flag=1;next} 
/==================/{flag=0} flag { print }" CHANGELOG-$major_version.x >> 
/tmp/release-$version-sigs.txt
+        awk "/Release Notes - Wicket - Version $version/{flag=1;next} 
/==================/{flag=0} flag { print }" CHANGELOG-$major_version.x >> 
"$sigs"
     fi
 }
 
@@ -187,7 +190,7 @@ Staging git repository data:
 
 " | tail -n+2 > release-vote.txt
 
-    cat /tmp/release-$version-sigs.txt >> release-vote.txt
+    cat "$sigs" >> release-vote.txt
        git add release-vote.txt
 }
 
@@ -239,7 +242,7 @@ Have fun!
 
 " | tail -n+2 > release-announce.txt
 
-    cat /tmp/release-$version-sigs.txt >> release-announce.txt
+    cat "$sigs" >> release-announce.txt
        git add release-announce.txt
 }
 

Reply via email to