dashorst opened a new pull request, #1754:
URL: https://github.com/apache/wicket/pull/1754

   `MigrateToWicket10` runs OpenRewrite's `JavaxMigrationToJakarta`. In 
rewrite-migrate-java 3.26.0, which `wicket-10.x` ships, that recipe rewrites 
Jetty 9's `org.eclipse.jetty.websocket:javax-websocket-server-impl` to 
`org.eclipse.jetty.websocket:websocket-javax-server:12.0.x`. That artifact only 
exists for Jetty 10 (latest 10.0.26), so the literal `12.0.x` ends up in the 
pom and the project no longer resolves. rewrite-migrate-java 3.42.1 maps it to 
`org.eclipse.jetty.ee9.websocket:jetty-ee9-websocket-jakarta-server` instead.
   
   This PR brings master's bump (003cf99a60: rewrite-migrate-java 3.26.0 → 
3.42.1, a `jackson-dataformat-yaml` exclusion, `rewrite-static-analysis` 
managed at 2.41.1) to `wicket-10.x`, together with `rewrite-recipe-bom` 3.23.0 
→ 3.26.1. The bom has to move as well. With 3.23.0, every 
`MigrateToWicket10Test` fails recipe validation ("DeclarativeRecipe must not 
contain uninitialized preconditions"), because 3.42.1 needs a newer OpenRewrite 
core. Master reached 3.26.1 through four dependabot bumps.
   
   ## Proof
   
   A Wicket 9.25.0 quickstart, migrated with `rewrite-maven-plugin` 6.46.1 and 
`-Drewrite.activeRecipes=org.apache.wicket.MigrateToWicket10`:
   
   | | `wicket-migration:10.12.0` (released) | this branch (`10.13.0-SNAPSHOT`) 
|
   |---|---|---|
   | websocket server dependency | 
`org.eclipse.jetty.websocket:websocket-javax-server:12.0.x` | 
`org.eclipse.jetty.ee9.websocket:jetty-ee9-websocket-jakarta-server:12.0.40` |
   | `mvn verify` on the result | `Could not resolve dependencies` 
(`websocket-javax-server:jar:12.0.x` is missing) | dependencies resolve; 
compilation stops in the quickstart's Jetty 9 `Start.java` |
   
   The quickstart's `Start.java` (a test-scope Jetty launcher using 
`org.eclipse.jetty.webapp` and `jsr356`) is not migrated to Jetty 12 by any 
recipe, with or without this PR, and still needs porting by hand.
   
   `MigrateToWicket10Test` passes (2 tests), and `mvn clean verify -Pjs-test` 
is green.
   
   ## Scope
   
   `wicket-10.x` only. Master already has these versions. This PR is 
independent of #1753.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to