dashorst opened a new pull request, #1869:
URL: https://github.com/apache/wicket/pull/1869

   Adds `REVIEW.md`, the checklist a review of a pull request applies, and 
points to it from `AGENTS.md`. Closes #1868 once agreed.
   
   `AGENTS.md` covers how to write a change. `REVIEW.md` adds what is easy to 
miss when a change otherwise looks right:
   
   - **License compliance**: ASF headers, the ASF license categories of new 
dependencies, and `LICENSE`, `LICENSE-binary`, `NOTICE` and `licenses/` for 
third-party material copied into the tree.
   - **OSGi and JPMS**: exports and imports stay consistent between `osgi.*` 
properties, `module-info.java` and the pom. wicket-core and wicket-extensions 
list their exports explicitly, and optional dependencies end up as 
`resolution:=optional`.
   - **Performance**: hot paths keep their complexity and footprint, or the 
commit justifies the cost with numbers from wicket-benchmarks. Removing a 
dependency is no reason to give up a performance gain (see the first draft of 
#1865).
   - **Serialization**: page size and compatibility of stored pages; a changed 
serialized form only in a major release, described in the migration guide.
   - **Accessibility**: WCAG 2.2 level AA for markup, components and JavaScript 
that render UI, examples included.
   - **Documentation**: Javadoc, user guide and `migration-to-<major>.md` 
updated in the same pull request.
   - **Tests**: a failing test for every fix, `*Test.java` naming, test 
placement.
   
   Points for discussion: WCAG 2.2 level AA is a target I picked as the common 
baseline; the project hasn't stated one before. Enforcement here means agents 
check against the list before handing a change over. A pull request template 
with the same checklist would put it in front of human contributors too, which 
I left out to keep the PR small.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to