Swarneil1905 opened a new pull request, #1874: URL: https://github.com/apache/wicket/pull/1874
Fixes #1866. PageParameters.equals() ignores named parameter order, but hashCode() used the ordered list hash. Equal parameters could therefore produce different hashes and fail HashMap lookups. Sum the hashes of all named pairs, including duplicates. Indexed parameter and fragment hashing stay unchanged. Regression tests cover reordered pairs, duplicates, empty parameters, and HashMap lookup and replacement. Validation on Windows with Java 21: - PageParametersTest: 21 tests passed. - All 34 reactor modules passed with the js-test profile and ExampleTitlesTest excluded. ExampleTitlesTest fails on Windows because its class name conversion handles forward slashes but leaves backslashes intact. The test was excluded without changing its source. The JavaScript ChannelManager clean up test failed once, then passed both on its own and in the final reactor run. Final verification command: mvn verify -Pjs-test "-Dtest=!ExampleTitlesTest" "-Dsurefire.failIfNoSpecifiedTests=false" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
